vvysotskyi commented on a change in pull request #1847: DRILL-7253: Read Hive
struct w/o nulls
URL: https://github.com/apache/drill/pull/1847#discussion_r317208189
##########
File path: exec/vector/src/main/codegen/templates/HolderReaderImpl.java
##########
@@ -319,7 +319,9 @@ public void copyAsField(String name, MapWriter writer) {
<#else>
<#if !(minor.class == "Decimal9" || minor.class == "Decimal18")>
public void copyAsValue(${minor.class?cap_first}Writer writer) {
- writer.write${minor.class}(<#list fields as field>holder.${field.name}<#if
field_has_next>, </#if></#list>);
+ if (isSet()) {
Review comment:
Could you please also add this check to `copyAsField` methods.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
