KazydubB commented on a change in pull request #1855: DRILL-7252: Read Hive map
using Dict<K,V> vector
URL: https://github.com/apache/drill/pull/1855#discussion_r324232593
##########
File path: exec/vector/src/main/codegen/templates/ListWriters.java
##########
@@ -253,6 +253,9 @@ public void startList() {
currentChildIndex = container.getMutator().add(idx());
if(writer != null) {
writer.setPosition(currentChildIndex);
+ if (writer instanceof RepeatedDictWriter) {
Review comment:
is it possible to use `mode == Mode.IN_DICT` instead of `instanceof`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
