arina-ielchiieva commented on a change in pull request #1860: DRILL-7357:
Expose Drill Metastore data through information_schema
URL: https://github.com/apache/drill/pull/1860#discussion_r329518373
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/store/ischema/Records.java
##########
@@ -503,12 +568,97 @@ public Column(String catalog, String schemaName, String
tableName, RelDataTypeFi
this.COLUMN_SIZE = null;
break;
}
+ this.COLUMN_FORMAT = null;
+ this.NUM_NULLS = null;
+ this.MIN_VAL = null;
+ this.MAX_VAL = null;
+ this.NDV = null;
+ this.EST_NUM_NON_NULLS = null;
+ }
+ public Column(String catalog, String schemaName, String tableName, String
columnName,
Review comment:
Both constructors cannot be combined since they determine `Record.Column`
properties based on different sources. One uses `RelDataTypeField`, another
`ColumnMetadata`, `ColumnStatistics` and additional properties, mostly relying
on `TypeProtos.MajorType`. Logic go obtaining `Record.Column` is different, so
I suggest we leave both constructors.
Personally, I would prefer to remove some of the properties from
`Record.Column`, like `NUMERIC_PRECISION_RADIX` etc. since I am not sure how
much value they bring but I had to leave them for backward compatibility.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
