arina-ielchiieva commented on a change in pull request #1864: DRILL-7351: Added
tokens to Web forms to prevent CSRF attacks
URL: https://github.com/apache/drill/pull/1864#discussion_r330020831
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/util/Utilities.java
##########
@@ -32,10 +32,14 @@
import org.apache.drill.exec.proto.BitControl.QueryContextInformation;
import org.apache.drill.exec.proto.ExecProtos;
import org.apache.drill.exec.proto.helper.QueryIdHelper;
+import org.apache.drill.exec.server.rest.WebServerConstants;
import org.apache.drill.shaded.guava.com.google.common.base.Preconditions;
import org.apache.drill.shaded.guava.com.google.common.base.Predicate;
import org.apache.drill.shaded.guava.com.google.common.collect.Iterables;
+import javax.servlet.http.HttpServletRequest;
+import javax.servlet.http.HttpSession;
+
public class Utilities {
Review comment:
Does not really seem to be ad good place for this utility method since it is
closely connected with web resources please move it to appropriate class in
`org.apache.drill.exec.server.rest` package or create one if absent.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
