arina-ielchiieva commented on a change in pull request #1868: DRILL-7377:
Nested schemas for dynamic EVF columns
URL: https://github.com/apache/drill/pull/1868#discussion_r331964190
##########
File path:
exec/vector/src/main/java/org/apache/drill/exec/vector/accessor/writer/AbstractTupleWriter.java
##########
@@ -205,20 +208,29 @@ public int addColumnWriter(AbstractObjectWriter
colWriter) {
@Override
public int addColumn(ColumnMetadata column) {
- if (listener == null) {
- throw new UnsupportedOperationException("addColumn");
- }
+ verifyAddColumn(column.name());
final AbstractObjectWriter colWriter = (AbstractObjectWriter)
listener.addColumn(this, column);
return addColumnWriter(colWriter);
}
@Override
public int addColumn(MaterializedField field) {
+ verifyAddColumn(field.getName());
+ final AbstractObjectWriter colWriter = (AbstractObjectWriter)
listener.addColumn(this, field);
Review comment:
It would be nice if we could ged rid of casting to abstract version of
object writer. We can add necessary methods to `ObjectWriter` interface or
return `AbstractObjectWriter`. What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
