paul-rogers edited a comment on issue #1871: DRILL-7403: Validate batch checks, vector integretity in unit tests URL: https://github.com/apache/drill/pull/1871#issuecomment-543515384 @arina-ielchiieva, addressed the comments. Since they were minor, went ahead and squashed commits. Local tests passed up to the one that usually fails for me: ``` [ERROR] Errors: [ERROR] TestDynamicUDFSupport.testReRegisterTheSameJarWithDifferentContent:600->BaseTestQuery.testRunAndReturn:340 ยป Rpc ``` Tried enabling the check for only the "new" scan. But, somehow, this still checked the Parquet reader: ``` [INFO] Running org.apache.drill.exec.store.parquet2.TestDrillParquetReader columns-offsets - UInt4Vector: Invalid offset at index 2049 = 4098 exceeds maximum of 4096 columns-offsets - UInt4Vector: Invalid offset at index 2050 = 4100 exceeds maximum of 4096 ``` Since this PR is just about introducing the test code, I went ahead and disabled calls to the code. Later PRs will try to enable the checks operator-by-operator so we can find issues gradually.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
