arina-ielchiieva commented on a change in pull request #1879: DRILL-5674: Support ZIP compression URL: https://github.com/apache/drill/pull/1879#discussion_r337452079
########## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/ZipCodec.java ########## @@ -0,0 +1,141 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.drill.exec.store.dfs; + +import org.apache.hadoop.io.compress.CompressionInputStream; +import org.apache.hadoop.io.compress.CompressionOutputStream; +import org.apache.hadoop.io.compress.DefaultCodec; + +import java.io.IOException; +import java.io.InputStream; +import java.io.OutputStream; +import java.util.zip.ZipEntry; +import java.util.zip.ZipInputStream; +import java.util.zip.ZipOutputStream; + +/** + * ZIP codec implementation which cna read or create single entry. + * <p/> + * Note: Do not rename this class. Class naming must be 'ZipCodec' so it can be mapped by + * {@link org.apache.hadoop.io.compress.CompressionCodecFactory} to the 'zip' extension. + */ +public class ZipCodec extends DefaultCodec { + + private static final String EXTENSION = ".zip"; Review comment: `org.apache.hadoop.io.compress` supports gzip, bzip2 out of box. We are adding only zip codec implementation since it is missing in `org.apache.hadoop.io.compress` library. Regarding `.tar.gz`, I am not sure how to support since it basically two compressions one over another and mostly is used for folders. Since Drill allows only to read compressed files not folders, I think for now we don't need it. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
