agozhiy commented on a change in pull request #1864: DRILL-7351: Added tokens 
to Web forms to prevent CSRF attacks
URL: https://github.com/apache/drill/pull/1864#discussion_r339075500
 
 

 ##########
 File path: exec/java-exec/src/main/resources/rest/storage/list.ftl
 ##########
 @@ -190,7 +190,7 @@
               <button type="button" class="btn btn-default" 
data-dismiss="modal">Close</button>
               <button type="submit" class="btn btn-primary" 
onclick="doCreate()">Create</button>
             </div>
-            <input type="hidden" name="csrfToken" 
value="${model.getCsrfToken()}">
+            <input type="hidden" name="csrfToken" 
value="${model[0].getCsrfToken()}">
 
 Review comment:
   Now we have one model per plugin, but they all contain the same CSRF token. 
In case when there is no plugins one empty model with the token is created.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to