paul-rogers commented on issue #1870: DRILL-7359: Add support for DICT type in RowSet Framework URL: https://github.com/apache/drill/pull/1870#issuecomment-549198995 @KazydubB, thanks much for the changes. This is a complex area. It looks like you are getting a good understanding. My focus on this review is to help you define the simplest implementation for the schema builder. Maybe we can get that part finished up. Then, I made a suggestion about how to structure the Dict writer. The new design here is much improved. Still, I think we can improve it a bit more. Everything said for the writer applies to the reader, so I didn't repeat the comments there. Once we get the API correct, then I'll dive into the implementation details. That should be a quick review if the we agree on the API, and if you have complete unit tests.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
