vvysotskyi commented on a change in pull request #1886: DRILL-7273: Introduce 
operators for handling metadata
URL: https://github.com/apache/drill/pull/1886#discussion_r344841819
 
 

 ##########
 File path: 
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillSqlWorker.java
 ##########
 @@ -131,7 +130,9 @@ private static PhysicalPlan convertPlan(QueryContext 
context, String sql, Pointe
           "Will sync remote and local function registries if needed and retry 
" +
           "in case if issue was due to missing function implementation.", e);
       if (context.getFunctionRegistry().syncWithRemoteRegistry(
-          context.getDrillOperatorTable().getFunctionRegistryVersion())) {
+              context.getDrillOperatorTable().getFunctionRegistryVersion())
 
 Review comment:
   Thanks, `CTAS` with `EXPLAIN` also should be present in this check. The goal 
was to avoid rerunning queries that cannot have UDFs but failed with an 
exception. For example, for Metastore ANALYZE, Metastore is being disabled 
using a query-level option before plan constructing but after the check that it 
was enabled. So after rerunning such a query, it will fail with another 
exception that Metastore is disabled.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to