paul-rogers commented on a change in pull request #1897: DRILL-7442: Create multi-batch row set reader URL: https://github.com/apache/drill/pull/1897#discussion_r345589445
########## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/rowSet/RowSet.java ########## @@ -98,6 +98,8 @@ SelectionVectorMode indirectionType(); + void print(); Review comment: Actually, we agreed we would not call methods for printing to output in production code. `RowSet` is used often in testing where it is often handy to print the contents of row sets while debugging. Marked this method as `@VisibleForTesting`. While we could do: ``` System.out.println(rowSet.toString()); ``` I am lazy, just easier to write: ``` rowSet.print(); ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
