arina-ielchiieva commented on a change in pull request #1907: DRILL-7450:
Improve performance for ANALYZE command
URL: https://github.com/apache/drill/pull/1907#discussion_r350177927
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/HashAggTemplate.java
##########
@@ -779,7 +780,20 @@ private void allocateOutgoing(int records) {
while (outgoingIter.hasNext()) {
ValueVector vv = outgoingIter.next().getValueVector();
- AllocationHelper.allocatePrecomputedChildCount(vv, records,
maxColumnWidth, 0);
+ // Prevent allocating complex vectors here to avoid losing their content
+ // since their writers will still be used in generated code
+ switch (vv.getField().getType().getMinorType()) {
Review comment:
Maybe use `Types.isComplex` and `Types.isUnion`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
