paul-rogers commented on a change in pull request #1910: DRILL-7393: Revisit
Drill tests to ensure that patching is executed b…
URL: https://github.com/apache/drill/pull/1910#discussion_r352251533
##########
File path: common/src/test/java/org/apache/drill/test/BaseTest.java
##########
@@ -15,24 +15,25 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
-package org.apache.drill.exec.expr;
+package org.apache.drill.test;
-import org.apache.drill.BaseTestQuery;
-import org.apache.drill.common.util.TestTools;
-import org.junit.Test;
+import org.apache.drill.common.util.GuavaPatcher;
+import org.apache.drill.common.util.ProtobufPatcher;
-public class TestPrune extends BaseTestQuery {
+public class BaseTest {
- String MULTILEVEL = TestTools.getWorkingPath() +
"/../java-exec/src/test/resources/multilevel";
-
- @Test
- public void pruneCompound() throws Exception {
- test(String.format("select * from dfs.`%s/csv` where x is null and dir1 in
('Q1', 'Q2')", MULTILEVEL));
- }
-
- @Test
- public void pruneSimple() throws Exception {
- test(String.format("select * from dfs.`%s/csv` where dir1 in ('Q1',
'Q2')", MULTILEVEL));
+ static {
+ /*
+ * HBase and MapR-DB clients use older version of protobuf,
+ * and override some methods that became final in recent versions.
+ * This code removes these final modifiers.
Review comment:
Shouldn't these clients be addressed directly? We're doing patching for
tests, but what about production code? Possible solutions:
* Load these clients into their own class loader so their dependencies do
not conflict.
* Shade them.
* Upgrade to newer versions that use more recent Guava libraries.
* Do the patching within Drill: perhaps have a plugin-specific startup event
that can trigger patching where needed.
* Lobby the creators of the libraries to fix the problems.
My concern is that changing all our tests to work around bugs in external
libraries is an unstable solution: we'll find ourselves doing more of this each
time some new external conflict arises.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
