vvysotskyi commented on a change in pull request #1910: DRILL-7393: Revisit Drill tests to ensure that patching is executed b… URL: https://github.com/apache/drill/pull/1910#discussion_r352552524
########## File path: common/src/test/java/org/apache/drill/test/BaseTest.java ########## @@ -15,24 +15,25 @@ * See the License for the specific language governing permissions and * limitations under the License. */ -package org.apache.drill.exec.expr; +package org.apache.drill.test; -import org.apache.drill.BaseTestQuery; -import org.apache.drill.common.util.TestTools; -import org.junit.Test; +import org.apache.drill.common.util.GuavaPatcher; +import org.apache.drill.common.util.ProtobufPatcher; -public class TestPrune extends BaseTestQuery { +public class BaseTest { Review comment: Patching is done for production code also, so with patching, we make testing env closer to the production one. Also, pathing is required for a newer hadoop libraries version which is used in exec module, so comment in `BaseTest` perhaps should be updated a little bit. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services