paul-rogers commented on issue #1910: DRILL-7393: Revisit Drill tests to ensure that patching is executed b… URL: https://github.com/apache/drill/pull/1910#issuecomment-560512155 @agozhiy, thank you for the explanation. To summarize, when we run a Drillbit, patching occurs. This means that any test that starts a Drillbit should *not* need to patch. In fact, we probably *do not want* to patch: we need the tests to verify that the Drillbit does any needed patching on its own. We have tests that do not start a Drillbit; these tend to test specific bits of the system. Such tests should not need patching unless they pull in one of the affected dependencies. In this case, it makes sense for the test to explicitly declare that it needs patching so we can verify that the dependency works as needed. From this, we get the following suggestion: * Any test that derives from `BaseTestQuery` or `ClusterTest` will start a Drillbit. So the test *should not* attempt to patch as doing so will hide any Drillbit patching errors. * Any other test should optionally invoke patching if needed for the specific item under test. (For example, if we have HBase, MapR or other tests that do unit tests without a Drillbit.) In this case, part of the test is to verify that the patching works for that dependency. A result of this thinking is that we *should not* create a new base test class that always does patching. I wonder, how does the result above differ from what we already do?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
