vvysotskyi commented on issue #1910: DRILL-7393: Revisit Drill tests to ensure 
that patching is executed b…
URL: https://github.com/apache/drill/pull/1910#issuecomment-560518278
 
 
   @paul-rogers, your suggestion sounds reasonable to me, but one more thing 
should be mentioned - is that we use guava in test classes also, so there are 
possible cases when class is loaded before Drill is patched, and therefore 
patching is failed. I can observe such scenarios at least for `Preconditions` 
class.
   
   Also, before the changes in this PR, patching was produced in `DrillTest` 
static block (one more common parent for a lot of test classes).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to