vvysotskyi commented on a change in pull request #1922: DRILL-7476: Set lastSet on TransferPair copies URL: https://github.com/apache/drill/pull/1922#discussion_r356481536
########## File path: exec/java-exec/src/main/java/org/apache/drill/exec/record/FragmentWritableBatch.java ########## @@ -23,65 +23,87 @@ import org.apache.drill.exec.proto.UserBitShared.QueryId; import org.apache.drill.exec.proto.UserBitShared.RecordBatchDef; -public class FragmentWritableBatch{ - static final org.slf4j.Logger logger = org.slf4j.LoggerFactory.getLogger(FragmentWritableBatch.class); +public class FragmentWritableBatch { private static RecordBatchDef EMPTY_DEF = RecordBatchDef.newBuilder().setRecordCount(0).build(); private final ByteBuf[] buffers; private final FragmentRecordBatch header; - public FragmentWritableBatch(final boolean isLast, final QueryId queryId, final int sendMajorFragmentId, final int sendMinorFragmentId, final int receiveMajorFragmentId, final int receiveMinorFragmentId, final WritableBatch batch){ - this(isLast, queryId, sendMajorFragmentId, sendMinorFragmentId, receiveMajorFragmentId, new int[]{receiveMinorFragmentId}, batch.getDef(), batch.getBuffers()); + public FragmentWritableBatch(boolean isLast, QueryId queryId, + int sendMajorFragmentId, int sendMinorFragmentId, + int receiveMajorFragmentId, int receiveMinorFragmentId, + WritableBatch batch){ + this(isLast, queryId, sendMajorFragmentId, sendMinorFragmentId, receiveMajorFragmentId, + new int[]{receiveMinorFragmentId}, batch.getDef(), batch.getBuffers()); } - public FragmentWritableBatch(final boolean isLast, final QueryId queryId, final int sendMajorFragmentId, final int sendMinorFragmentId, final int receiveMajorFragmentId, final int[] receiveMinorFragmentIds, final WritableBatch batch){ - this(isLast, queryId, sendMajorFragmentId, sendMinorFragmentId, receiveMajorFragmentId, receiveMinorFragmentIds, batch.getDef(), batch.getBuffers()); + public FragmentWritableBatch(boolean isLast, QueryId queryId, + int sendMajorFragmentId, int sendMinorFragmentId, + int receiveMajorFragmentId, int[] receiveMinorFragmentIds, + WritableBatch batch){ + this(isLast, queryId, sendMajorFragmentId, sendMinorFragmentId, + receiveMajorFragmentId, receiveMinorFragmentIds, batch.getDef(), + batch.getBuffers()); } - private FragmentWritableBatch(final boolean isLast, final QueryId queryId, final int sendMajorFragmentId, final int sendMinorFragmentId, final int receiveMajorFragmentId, final int[] receiveMinorFragmentId, final RecordBatchDef def, final ByteBuf... buffers){ + private FragmentWritableBatch(boolean isLast, QueryId queryId, + int sendMajorFragmentId, int sendMinorFragmentId, + int receiveMajorFragmentId, int[] receiveMinorFragmentId, + RecordBatchDef def, ByteBuf... buffers){ Review comment: ```suggestion RecordBatchDef def, ByteBuf... buffers) { ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services