paul-rogers commented on issue #1922: DRILL-7476: Set lastSet on TransferPair copies URL: https://github.com/apache/drill/pull/1922#issuecomment-564864142 @vvysotskyi, I had a nice unit test that I used when debugging. However, it turns out that we can't use it in Maven: the information in the system table ('connections') changes too much. (One row for one connection when run in the IDE, but 9 (?) rows when run in Maven.) I can perhaps add a different test: the problem should appear anytime a `LIMIT` is done where the limit amount is the same as the row count. But, to create such a test, I'll need to do it on master before this fix (to verify that the test catches the error.) Even better, this PR does include a new batch check that *did* catch the error. If the error occurs, all offsets in a VARCHAR offset vector will be 0. A check verifies that the largest offset is the same size as the data vector. If this bug occurs, that check will trigger and we'll see an error.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
