paul-rogers commented on a change in pull request #1925: DRILL-7472: Fix ser /
de for sys and information_schema schemas queries
URL: https://github.com/apache/drill/pull/1925#discussion_r356990235
##########
File path:
exec/java-exec/src/test/java/org/apache/drill/exec/store/sys/TestSystemTable.java
##########
@@ -61,6 +61,12 @@ public void optionsOrderBy() throws Exception {
test("select * from sys.options order by name");
}
+ @Test
+ public void testSerDe() throws Exception {
+ PlanTestBase.testPhysicalPlanExecutionBasedOnQuery("select * from
sys.threads");
+ PlanTestBase.testPhysicalPlanExecutionBasedOnQuery("select * from
sys.connections limit 10");
Review comment:
This test is sort of OK. (It converts the plan to a physical plan, then
executes it.) But, we don't check the results.
A better SerDe test is to convert the object to JSON, then convert back and
compare the two objects. (I have such a test I added for the column metadata
serialization for which I need to issue a PR after the release.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
