arina-ielchiieva commented on a change in pull request #1925: DRILL-7472: Fix
ser / de for sys and information_schema schemas queries
URL: https://github.com/apache/drill/pull/1925#discussion_r357049941
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/store/ischema/InfoSchemaGroupScan.java
##########
@@ -111,12 +114,8 @@ public GroupScan clone(List<SchemaPath> columns) {
return new InfoSchemaGroupScan(this);
}
- public void setFilterPushedDown(boolean status) {
- this.isFilterPushedDown = status;
- }
-
@JsonIgnore
public boolean isFilterPushedDown() {
- return isFilterPushedDown;
+ return filter != null;
Review comment:
I have removed this flag since instead of using additional boolean variable
(which by the way was not serialized), it can be replaced with check if filter
is set or not. Filter is set only if it was pushed down, so thus checking that
filter was set `will prevent Calcite from pushing filters down multiple times`.
https://github.com/apache/drill/blob/master/exec/java-exec/src/main/java/org/apache/drill/exec/store/ischema/InfoSchemaPushFilterIntoRecordGenerator.java#L94-L99
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
