paul-rogers commented on issue #1923: DRILL-7479: Partial fixes for metadata parameterized type issues URL: https://github.com/apache/drill/pull/1923#issuecomment-565176282 Tried to clean up a few more warnings. Have found even more cases where we want to assign types statically, but work with them generically at runtime. Had to add some horrible hacks to cast away the (unknown) type. Also, found another issue in `FilterExpression.Visitor`. The predicates are parameterized, but untyped in the visitor class. Typing them causes many tests to fail. So, we've got a case where we *must* abuse the Java type system to get the code to work. That is a strong "code smell" that some adjusting wants to be done. The one issue I can see is that some of the proposed changes will change the serialized metadata format. If anyone starts to use the features from this release, some form of upgrade will be needed when that user upgrades. This incompatibility could be a reason to fix the issues now rather than later.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
