cgivre opened a new pull request #1932: DRILL-7485: NPE on PCAP Batch Reader
URL: https://github.com/apache/drill/pull/1932
 
 
   The Drill PCAP reader was throwing a NPE if it encountered a packet with a 
null IP address.  This phenomenon can occur in ARP packets before IP addresses 
are resolved to MAC addresses.  
   
   The PR adds a function to `Packet.java` that checks whether the IP address 
is `null`, and if is, returns an empty string.  If the IP addresses are 
populated, it returns the String version of the IP address.
   
   
https://github.com/cgivre/drill/blob/93e0275280e88a0a83aa4fc7e6f0ed907ac576d7/exec/java-exec/src/main/java/org/apache/drill/exec/store/pcap/decoder/Packet.java#L186-#L202
   
   I added a small test file, as well as a new unit test to confirm the 
functionality. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to