cgivre commented on a change in pull request #1932: DRILL-7485: NPE on PCAP
Batch Reader
URL: https://github.com/apache/drill/pull/1932#discussion_r357836096
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/store/pcap/PcapBatchReader.java
##########
@@ -406,8 +406,8 @@ private void addDataToTable(Packet packet, int
networkType, RowSetLoader rowWrit
srcMacAddressWriter.setString(packet.getEthernetSource());
dstMacAddressWriter.setString(packet.getEthernetDestination());
- dstIPWriter.setString(packet.getDst_ip().getHostAddress());
- srcIPWriter.setString(packet.getSrc_ip().getHostAddress());
+ dstIPWriter.setString(packet.getDst_ip_String());
Review comment:
I was trying to keep the null check out of the batch reader, but in the end
I had to put it there. So yes... now this is addressed and the values are null
if in fact that's the case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
