vvysotskyi commented on a change in pull request #1932: DRILL-7485: NPE on PCAP
Batch Reader
URL: https://github.com/apache/drill/pull/1932#discussion_r357838630
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/store/pcap/decoder/Packet.java
##########
@@ -183,6 +183,24 @@ public InetAddress getDst_ip() {
return getIPAddress(false);
}
+ public String getSrc_ip_String() {
Review comment:
Also please rename methods here (including methods above) according to JCC,
for example to something like `getSourceHostAdress`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
