vvysotskyi commented on a change in pull request #1935: DRILL-7483: Add support 
for 12 and 13 java versions
URL: https://github.com/apache/drill/pull/1935#discussion_r358243346
 
 

 ##########
 File path: 
contrib/storage-hive/core/src/test/java/org/apache/drill/exec/hive/complex_types/TestHiveArrays.java
 ##########
 @@ -59,6 +60,7 @@
 
   @BeforeClass
   public static void setUp() throws Exception {
+    assumeTrue("Skipping tests since Hive supports only JDK 8.", 
HiveTestUtilities.supportedJavaVersion());
 
 Review comment:
   Thanks for pointing this, I have created `HiveClusterTest` for this and 
extended it where possible. For other places, I have added a call of its static 
method, so in future when we will use Hive which supports JDK 9+, it would be 
easier to find and remove its usage.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to