[GitHub] [drill] ihuzenko commented on a change in pull request #1929: DRILL-6832: Remove the old "unmanaged" external sort

[GitBox]

ihuzenko commented on a change in pull request #1929: DRILL-6832: Remove the 
old "unmanaged" external sort
URL: https://github.com/apache/drill/pull/1929#discussion_r360518409
 
 

 ##########
 File path: 
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/PriorityQueueCopierTemplate.java
 ##########
 @@ -17,94 +17,95 @@
  */
 package org.apache.drill.exec.physical.impl.xsort;
 
-import io.netty.buffer.DrillBuf;
-
 import java.io.IOException;
 import java.util.List;
 
 import javax.inject.Named;
 
 import org.apache.drill.exec.exception.SchemaChangeException;
 import org.apache.drill.exec.memory.BufferAllocator;
-import org.apache.drill.exec.ops.FragmentContext;
 import org.apache.drill.exec.record.VectorAccessible;
 import org.apache.drill.exec.record.VectorAccessibleUtilities;
 import org.apache.drill.exec.record.selection.SelectionVector4;
 
+import io.netty.buffer.DrillBuf;
 
 public abstract class PriorityQueueCopierTemplate implements 
PriorityQueueCopier {
+//  private static final org.slf4j.Logger logger = 
org.slf4j.LoggerFactory.getLogger(PriorityQueueCopierTemplate.class);
 
   private SelectionVector4 vector4;
   private List<BatchGroup> batchGroups;
   private VectorAccessible hyperBatch;
   private VectorAccessible outgoing;
   private int size;
-  private int queueSize;
+  private int queueSize = 0;
 
 Review comment:
   ```suggestion
     private int queueSize;
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services