cgivre commented on a change in pull request #1941: DRILL-7495: Excel Reader
Not Parsing Dates Correctly in First Column
URL: https://github.com/apache/drill/pull/1941#discussion_r361338355
##########
File path:
contrib/format-excel/src/test/java/org/apache/drill/exec/store/excel/TestExcelFormat.java
##########
@@ -382,6 +382,26 @@ public void testExplicitSomeQueryWithCompressedFile()
throws Exception {
new RowSetComparison(expected).verifyAndClearAll(results);
}
+ @Test
+ public void testFileWithDoubleDates() throws Exception {
+ String sql = "SELECT `Close Date`, `Type` FROM dfs.`excel/comps.xlsx`
WHERE style='Contemporary'";
Review comment:
I removed this and incorporated the data into the one test file. However,
the additional file was only 15kb. I understand that we want to keep Drill as
lightweight as possible, but does 15kb really make that much of a difference?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
