cgivre commented on a change in pull request #1778: Drill-7233: Format Plugin for HDF5 URL: https://github.com/apache/drill/pull/1778#discussion_r348189913
########## File path: contrib/format-hdf5/src/main/java/org/apache/drill/exec/store/hdf5/writers/HDF5DataWriter.java ########## @@ -0,0 +1,85 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.drill.exec.store.hdf5.writers; + +import ch.systemsx.cisd.hdf5.IHDF5Reader; +import org.apache.drill.exec.physical.resultSet.RowSetLoader; + +import java.util.ArrayList; + +public class HDF5DataWriter { + final RowSetLoader columnWriter; Review comment: I see why... Here was my thinking. The HDF5DataWriter represents one column. I wanted to have a bit of abstraction in the BatchReader. Even though it is technically a row writer, within the context of the HDF5 writers, it is only used to write one column, hence the name, column writer. I also chose that name because of how the HDF5 Library returns the data. If it is too confusing, I can call it something else. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
