arina-ielchiieva commented on a change in pull request #1778: Drill-7233:
Format Plugin for HDF5
URL: https://github.com/apache/drill/pull/1778#discussion_r363937373
##########
File path:
contrib/format-hdf5/src/main/java/org/apache/drill/exec/store/hdf5/writers/HDF5MapDataWriter.java
##########
@@ -52,8 +52,8 @@ public HDF5MapDataWriter(IHDF5Reader reader, RowSetLoader
columnWriter, String d
} catch (Exception e) {
throw UserException
.dataReadError()
- .message("Error writing Compound Field: ")
- .addContext("Error", e.getMessage())
+ .message("Error writing Compound Field: {}", e.getMessage())
+ .addContext("Error: {}", e.getStackTrace())
Review comment:
User execution will add stack trace itself, I believe, so adding it here can
be omitted. Just remove `addContext` since looks all is covered in message.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services