cgivre edited a comment on issue #1778: DRILL-7233: Format Plugin for HDF5 URL: https://github.com/apache/drill/pull/1778#issuecomment-572223262 Hi @arina-ielchiieva I fixed most of the issues you raised. I went through all the warnings in IntelliJ and addressed all the relevant ones. Just FYI, I did do this earlier in the review process, but it recommended some changes that didn't seem to pass review. For instance, changing a lot of the functions to package private. In any event, I removed almost all of the warnings. (There are two remaining in the batch reader relating to reworking a for loop.) There are two issues which I still need to look at from this review: 1. A generic matrix transpose method for primitives 2. Moving the `path` assignment to another method. Thank you for your help and patience with this. As you know, this isn't my full time job and this particular plugin is really complicated.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
