paul-rogers commented on issue #1913: DRILL-6953: EVF-based version of the JSON 
reader
URL: https://github.com/apache/drill/pull/1913#issuecomment-573497529
 
 
   Turns out that the v1 JSON reader will ignore all-null columns. In the test 
`TestStarQueries.testSelStarOrderBy`, we execute the following query:
   
   ```
   select * from cp.`employee.json` order by last_name
   ```
   
   Against the Foodmart file `customer.json` which has records like this:
   
   ```
   {"employee_id":53,...","end_date":null,"salary":...}
   ```
   
   The test is written to exclude `end_date` from a `SELECT *` query.
   
   In V2, however, `end_date` is included in the query. One can argue that 
'SELECT *' means "return all columns", not "return all columns except those 
that happen to be null in the first batch."
   
   See DRILL-7522.
   
   Modified the test to expect the old result for the V1 reader, the correct 
result for the V2. reader.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to