KazydubB commented on a change in pull request #1948: DRILL-7506: Simplify code
gen error handling
URL: https://github.com/apache/drill/pull/1948#discussion_r366001563
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/PhysicalOperatorUtil.java
##########
@@ -46,10 +46,13 @@ private PhysicalOperatorUtil() {}
}
/**
- * Helper method to create a list of MinorFragmentEndpoint instances from a
given endpoint assignment list.
+ * Helper method to create a list of MinorFragmentEndpoint instances from a
+ * given endpoint assignment list.
*
- * @param endpoints Assigned endpoint list. Index of each endpoint in list
indicates the MinorFragmentId of the
- * fragment that is assigned to the endpoint.
+ * @param endpoints
Review comment:
nit: no need to start from a new line.
Can you add Java docs to `@return`, please? :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
