arina-ielchiieva commented on a change in pull request #1778: DRILL-7233: 
Format Plugin for HDF5
URL: https://github.com/apache/drill/pull/1778#discussion_r366971754
 
 

 ##########
 File path: 
contrib/format-hdf5/src/test/java/org/apache/drill/exec/store/hdf5/TestHDF5Format.java
 ##########
 @@ -887,6 +887,69 @@ public void testExplicitQueryWithCompressedFile() throws 
RpcException, IOExcepti
     new RowSetComparison(expected).unorderedVerifyAndClearAll(results);
   }
 
+  @Test
+  public void testProvidedSchema() throws Exception {
 
 Review comment:
   @cgivre What is done? You must add schema inline for it to work. Now it is 
not working.
   See one more example from Avro: 
   
https://github.com/apache/drill/blob/5668cd762f6a394a9e73f5a8facff6c96a652b99/exec/java-exec/src/test/java/org/apache/drill/exec/store/avro/AvroFormatTest.java#L717

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to