vvysotskyi commented on a change in pull request #1970: DRILL-7504: Upgrade
Parquet library to 1.11.0
URL: https://github.com/apache/drill/pull/1970#discussion_r375874842
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetTableMetadataUtils.java
##########
@@ -280,6 +281,12 @@ public static PartitionMetadata
getPartitionMetadata(SchemaPath partitionColumn,
return columnsStatistics;
}
+ private static boolean invalidateStatistics(MetadataBase.ColumnMetadata
column,
+ MetadataBase.ParquetTableMetadataBase tableMetadata) {
+ return column.getMinValue() == null && column.getMaxValue() == null &&
column.getNulls() == 0
Review comment:
Is this check `column.getNulls() == 0` required here? If any of the `min` or
`max` are nulls, statistics should be treated as invalid. Also, please move
other checks from the method above into this method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
