Hi Charles,
Thanks for pointing me to the PRs. Really great contributions! Very helpful as
we create our Drillbit Docker support.
I commented on DRILL-7573 about how we might test the htpasswd feature. There
is lots of detail which, I hope, will help other contributors whose code needs
testing via the REST API and config settings. (We should gather up this stuff
and put it in the docs somewhere. That is a separate task.) I think the
techniques should work for DRILL-7562 as well.
Any questions, post them here or in PR 1977. Drill has lots of helpful test
gizmos, but they are not entirely obvious. And, we can always improve them.
Thanks,
- Paul
On Tuesday, February 11, 2020, 6:59:41 AM PST, Charles Givre
<[email protected]> wrote:
Hey Paul,
How's it going? A new Drill contributor submitted two PRs (DRILL-7562,
DRILL-7573) [1][2] for new authentication methods. In the PRs he wasn't sure
how to write unit tests for these. Aside from writing a unit test class that
calls each method do you know of any way to test authenticators? The code
looks fairly straightforward.
Thanks,
-- C
[1]: https://github.com/apache/drill/pull/1977
<https://github.com/apache/drill/pull/1977>
[2]: https://github.com/apache/drill/pull/1972
<https://github.com/apache/drill/pull/1972>
