paul-rogers commented on a change in pull request #1975: DRILL-7576: Fail fast
for operator errors
URL: https://github.com/apache/drill/pull/1975#discussion_r377999682
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/SpilledRecordBatch.java
##########
@@ -163,11 +162,12 @@ public IterOutcome next() {
container = vas.get();
}
} catch (IOException e) {
- lastOutcome = IterOutcome.STOP;
- throw UserException.dataReadError(e).addContext("Failed reading from a
spill file").build(logger);
+ throw UserException.dataReadError(e)
+ .addContext("Failed reading from a spill file")
+ .build(logger);
} catch (Exception e) {
- lastOutcome = IterOutcome.STOP;
- throw e;
+ // TODO: Catch the error closer to the cause and create a better error
message.
Review comment:
Cleaned up some. But others are really beyond the scope of this PR as they
require extra investigation. The "TODO" helps us remember to do that work.
Else, any one PR gets too large if we have to fix all Drill's challenges in a
single go.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
