dobesv commented on a change in pull request #1972: DRILL-7562: Support HTTP Basic authentication for REST API calls URL: https://github.com/apache/drill/pull/1972#discussion_r378419743
########## File path: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/auth/HttpBasicAuthSecurityHandler.java ########## @@ -0,0 +1,48 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.drill.exec.server.rest.auth; + +import org.apache.drill.common.exceptions.DrillException; +import org.apache.drill.exec.rpc.security.plain.PlainFactory; +import org.apache.drill.exec.server.DrillbitContext; +import org.eclipse.jetty.security.authentication.BasicAuthenticator; +import org.eclipse.jetty.util.security.Constraint; + +/** + * Implement HTTP Basic authentication for REST API access + */ +public class HttpBasicAuthSecurityHandler extends DrillHttpConstraintSecurityHandler { + @Override + public String getImplName() { + return Constraint.__BASIC_AUTH; + } + + @Override + public void doSetup(DrillbitContext dbContext) throws DrillException { + + // Check if PAMAuthenticator is available or not which is required for FORM authentication + if (!dbContext.getAuthProvider().containsFactory(PlainFactory.SIMPLE_NAME)) { + throw new DrillException("BASIC auth mechanism was configured but PLAIN mechanism is not enabled to provide an " + + "authenticator. Please configure user authentication with PLAIN mechanism and authenticator to use " + + "BASIC authentication"); + } Review comment: I don't think it's worth creating whole class just to reuse what amounts to basically 2 lines of code. Maybe something for another day. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
