vvysotskyi commented on a change in pull request #1971: DRILL-7572: JSON structure parser URL: https://github.com/apache/drill/pull/1971#discussion_r379387581
########## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/json/parser/JsonStructureOptions.java ########## @@ -0,0 +1,41 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.drill.exec.store.easy.json.parser; + +public class JsonStructureOptions { + public boolean allTextMode; + + /** + * Allow Infinity and NaN for float values. + */ + + public boolean allowNanInf; + + /** + * Describes whether or not this reader can unwrap a single root array record + * and treat it like a set of distinct records. + */ + public boolean skipOuterList = true; + public boolean skipMalformedRecords; + + /** + * Top-level event listeners. + */ + public ObjectListener rootListener; Review comment: If this class is designed as an argument holder for JSON readers, let's rename it to something like `JsonContext`, so there wouldn't be an assumption that it should store only options for JSON. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
