paul-rogers commented on issue #1981: DRILL-7583: Remove STOP status from 
operator outcome
URL: https://github.com/apache/drill/pull/1981#issuecomment-586762991
 
 
   @ihuzenko, sorry for being unclear. I am suggesting that this PR focus its 
functional change on removing the `STOP` status and revising the `kill()` 
method. There are cosmetic changes in files visited during this work; changes 
which should be low-risk and, IMHO, don't justify their own PR. (That said, we 
could certainly pull out cosmetic changes to a separate PR; some reviewers 
prefer that approach.)
   
   You make good suggestions about additional refactoring and we should make 
those improvements. To limit risk, I would suggest we tackle those in a 
separate PR.
   
   Does this work for you? Anything else that I should fix in this PR?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to