dobesv commented on issue #1787: DRILL-7203: Back button not working 
URL: https://github.com/apache/drill/pull/1787#issuecomment-587980323
 
 
   It seems like this problem came about because of the need to include the 
`User-Name` header with the form submission sometimes.  Someone introduced a 
sort of trick using XHR to submit the form and then replace the whole page body 
with the resulting page using `document.open` and `document.write`.  However, 
this method of replacing the page content does not add an element to the 
history.
   
   Is there a good reason why the username couldn't be included in the form 
data (instead of the custom header) to avoid this workaround?
   
   Alternatively, perhaps we could skip this workaround at least for people who 
are not using the `User-name` user impersonation feature - in this case a 
regular FORM submission would add to the history and reload the page in the 
"normal" way, avoiding this problem.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to