paul-rogers commented on a change in pull request #1996: DRILL-7603 Allow
default schema to be set for HTTP queries
URL: https://github.com/apache/drill/pull/1996#discussion_r384257662
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/QueryResources.java
##########
@@ -96,10 +95,12 @@ public QueryResult submitQueryJSON(QueryWrapper query)
throws Exception {
@Produces(MediaType.TEXT_HTML)
public Viewable submitQuery(@FormParam("query") String query,
@FormParam("queryType") String queryType,
- @FormParam("autoLimit") String autoLimit) throws
Exception {
+ @FormParam("autoLimit") String autoLimit,
+ @FormParam("defaultSchema") String
defaultSchema) throws Exception {
Review comment:
Nice improvement! I wonder, would it make sense to accept a list of
name/value pairs so we can also pass along session options? We could identify
the schema as a REST-specific property in that list.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
