arina-ielchiieva commented on a change in pull request #1994: DRILL-7203:
Accept impersonation userName as form field & fix back button for query page
URL: https://github.com/apache/drill/pull/1994#discussion_r385700278
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/QueryWrapper.java
##########
@@ -48,13 +53,21 @@
private final String queryType;
private final int autoLimitRowCount;
+ @Nullable
+ private final String userName;
+
private static MemoryMXBean memMXBean = ManagementFactory.getMemoryMXBean();
@JsonCreator
- public QueryWrapper(@JsonProperty("query") String query,
@JsonProperty("queryType") String queryType, @JsonProperty("autoLimit") String
autoLimit) {
+ public QueryWrapper(
+ @JsonProperty("query") String query,
+ @JsonProperty("queryType") String queryType,
+ @Nullable @JsonProperty("autoLimit") String autoLimit,
Review comment:
Please remove nullable annotation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
