paul-rogers commented on a change in pull request #2000: DRILL-7607: support dynamic credit based flow control URL: https://github.com/apache/drill/pull/2000#discussion_r385997319
########## File path: exec/java-exec/src/main/java/org/apache/drill/exec/work/batch/UnlimitedRawBatchBuffer.java ########## @@ -32,12 +32,22 @@ private final int softlimit; private final int startlimit; + private int runtimeSoftLimit = -1; + private int runtimeAckCredit = 10; + private int sampleTimes = 0; + private long totalBatchSize = 0l; Review comment: Nit: Octal 1? Maybe just plain `1` will be clearer. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
