weijietong commented on a change in pull request #2000: DRILL-7607: support
dynamic credit based flow control
URL: https://github.com/apache/drill/pull/2000#discussion_r386000834
##########
File path: protocol/src/main/protobuf/BitData.proto
##########
@@ -50,3 +52,7 @@ message RuntimeFilterBDef{
optional int32 hj_op_id = 7; // the operator id of the HashJoin which
generates this RuntimeFilter
optional int64 rf_identifier = 8; // the runtime filter identifier
}
+
+message AckWithCredit{
Review comment:
The protocol here changed at the DataTunnel between the execution nodes. The
client uses the UserChannel to talk with the execution cluster(see the
ScreenCreator's userConnection). So the client still uses the ACK to talk with
the cluster not the 'AckWithCredit' and it's backward compatibility.
To the execution cluster nodes inner, it's not possible to keep
compatibility by using different ack protocol. So the cluster manager should
upgrade their execution nodes at the same time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
