weijietong commented on issue #2000: DRILL-7607: support dynamic credit based flow control URL: https://github.com/apache/drill/pull/2000#issuecomment-593216689 @paul-rogers agree with your two configure item advice. But I suggest to configure `Enable/disable this feature` item as system level . Also by adding another `enableDynamicFC` at the `BitControll.Collector` , users can give a hint to a query to specify whether its query will enable this feature, that's to say it's a query level option. To spooling , I think it's been used if the planner choose to use MergeJoin or StreamingAgg. You could see the `HashToMergeExchange` which is the only class to set the spooling item as true.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
