vvysotskyi commented on a change in pull request #2009: DRILL-7622: Compilation
error when using HLL / TDigest with group by
URL: https://github.com/apache/drill/pull/2009#discussion_r387160301
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/DrillAggFuncHolder.java
##########
@@ -159,7 +160,11 @@ public HoldingContainer renderEnd(ClassGenerator<?>
classGenerator, HoldingConta
for (int i = 0; i < getWorkspaceVars().length; i++) {
if (getWorkspaceVars()[i].isInject()) {
workspaceJVars[i] = g.declareClassField("work",
g.getModel()._ref(getWorkspaceVars()[i].getType()));
- g.getBlock(BlockType.SETUP).assign(workspaceJVars[i],
g.getMappingSet().getIncoming().invoke("getContext").invoke("getManagedBuffer"));
+ g.getBlock(BlockType.SETUP).assign(
Review comment:
Could you please add checks similar to
[`DrillFuncHolder`](https://github.com/apache/drill/blob/755529f3ac7ca77797f68b60e1d0713ad126e227/exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/DrillFuncHolder.java#L186)
to ensure that the required variable should be injected, or even better -
reformat code if possible to use common code for these two classes to inject
variables in the same way?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
