vvysotskyi commented on a change in pull request #2020: DRILL-7634: Rollup of
code cleanup changes
URL: https://github.com/apache/drill/pull/2020#discussion_r390831009
##########
File path:
contrib/storage-hive/core/src/main/java/org/apache/drill/exec/expr/fn/HiveFunctionRegistry.java
##########
@@ -65,9 +65,9 @@
OracleSqlOperatorTable.TRANSLATE3.getName().toLowerCase())
.build();
- private ArrayListMultimap<String, Class<? extends GenericUDF>>
methodsGenericUDF = ArrayListMultimap.create();
- private ArrayListMultimap<String, Class<? extends UDF>> methodsUDF =
ArrayListMultimap.create();
- private HashSet<Class<?>> nonDeterministicUDFs = new HashSet<>();
+ private final ArrayListMultimap<String, Class<? extends GenericUDF>>
methodsGenericUDF = ArrayListMultimap.create();
+ private final ArrayListMultimap<String, Class<? extends UDF>> methodsUDF =
ArrayListMultimap.create();
+ private final HashSet<Class<?>> nonDeterministicUDFs = new HashSet<>();
Review comment:
```suggestion
private final Set<Class<?>> nonDeterministicUDFs = new HashSet<>();
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
