arina-ielchiieva commented on issue #1997: DRILL-7604: Allow session options to 
be set in HTTP queries
URL: https://github.com/apache/drill/pull/1997#issuecomment-598079843
 
 
   @dobesv the problem is that I don't really like parsing of the options 
introduced in this PR (its partially duplicates work done in Drill plus does 
parsing in slightly different way which will lead to discrepancies in future), 
there is much cleaner way to parse options, you need to pass option name, its 
kind and value. Please refer to my previous comment 
https://github.com/apache/drill/pull/1997/files#r391122758 so this PR needs 
re-working.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to