vvysotskyi commented on a change in pull request #2026: DRILL-7330: Implement
metadata usage for all format plugins
URL: https://github.com/apache/drill/pull/2026#discussion_r392718208
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/scan/framework/ShimBatchReader.java
##########
@@ -131,6 +131,8 @@ public boolean next() {
eof = ! reader.next();
}
+ readerOrchestrator.setEof(eof);
Review comment:
This flag is only required for `readerOrchestrator.endBatch()` method to
decide whether the file is empty and only its metadata row should be returned.
I have removed the field and introduced the new
`readerOrchestrator.endBatch(boolean)` method to make the code clearer.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
