arina-ielchiieva commented on a change in pull request #2030: Update docs for
Metastore to point that all format plugins are supported
URL: https://github.com/apache/drill/pull/2030#discussion_r394174790
##########
File path: _docs/connect-a-data-source/plugins/080-rdbms-storage-plugin.md
##########
@@ -9,14 +9,25 @@ As with any source, Drill supports joins within and between
all systems. Drill a
## Using the RDBMS Storage Plugin
-Drill is designed to work with any relational datastore that provides a JDBC
driver. Drill is actively tested with Postgres, MySQL, Oracle, MSSQL and Apache
Derby. For each system, you will follow three basic steps for setup:
+Drill is designed to work with any relational datastore that provides a JDBC
driver. Drill is actively tested with
+ Postgres, MySQL, Oracle, MSSQL, Apache Derby and H2. For each system, you
will follow three basic steps for setup:
1. [Install Drill]({{ site.baseurl
}}/docs/installing-drill-in-embedded-mode), if you do not already have it
installed.
2. Copy your database's JDBC driver into the jars/3rdparty directory.
(You'll need to do this on every node.)
3. Restart Drill. See [Starting Drill in Distributed
Mode]({{site.baseurl}}/docs/starting-drill-in-distributed-mode/).
- 4. Add a new storage configuration to Drill through the Web UI. Example
configurations for [Oracle](#Example-Oracle-Configuration), [SQL
Server](#Example-SQL-Server-Configuration),
[MySQL](#Example-MySQL-Configuration) and
[Postgres](#Example-Postgres-Configuration) are provided below.
-
-**Example: Working with MySQL**
+ 4. Add a new storage configuration to Drill through the Web UI. Example
configurations for [Oracle](#example-oracle-configuration), [SQL
Server](#example-sql-server-configuration),
[MySQL](#example-mysql-configuration) and
[Postgres](#example-postgres-configuration) are provided below.
+
+## Setting data source parameters in the storage plugin configuration
+
+Starting from Drill 1.18.0, new JDBC storage plugin configuration property
`sourceParameters` was introduced to allow
+ setting data source parameters described in
[HikariCP](https://github.com/brettwooldridge/HikariCP#configuration-knobs-baby).
+ Parameters names with incorrect naming will be ignored during plugin
configuration,
Review comment:
This is not true anymore, plugin setup will fail.
https://github.com/apache/drill/blob/master/contrib/storage-jdbc/src/test/java/org/apache/drill/exec/store/jdbc/TestDataSource.java#L95
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
